Skip to content

chore: Update annotate-snippets to 0.12.10 #149529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2025
Merged

chore: Update annotate-snippets to 0.12.10 #149529

merged 1 commit into from
Dec 2, 2025

Conversation

@Muscraft
Copy link
Member

@Muscraft Muscraft commented Dec 2, 2025

This PR updates annotate-snippets to 0.12.10, which includes a fix that modifies some test output.

@rustbot
Copy link
Collaborator

rustbot commented Dec 2, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 2, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu
jieyouxu approved these changes Dec 2, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test diffs look sensible to me, thanks. You can r=me once PR CI is green.

View changes since this review

@jieyouxu
Copy link
Member

jieyouxu commented Dec 2, 2025

r? me

@rustbot rustbot assigned jieyouxu and unassigned davidtwco Dec 2, 2025
@Muscraft
Copy link
Member Author

Muscraft commented Dec 2, 2025

@bors r=jieyouxu

@bors
Copy link
Collaborator

bors commented Dec 2, 2025

📌 Commit b2b059c has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2025
@bors
Copy link
Collaborator

bors commented Dec 2, 2025

⌛ Testing commit b2b059c with merge eca9d93...

@bors
Copy link
Collaborator

bors commented Dec 2, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing eca9d93 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 2, 2025
@bors bors merged commit eca9d93 into rust-lang:main Dec 2, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a80d39a (parent) -> eca9d93 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard eca9d93f9057f9a48ff691bd65e7daf2f94c1b67 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-debug: 6028.4s -> 7613.8s (+26.3%)
  2. x86_64-gnu-llvm-21-1: 2878.8s -> 3544.0s (+23.1%)
  3. pr-check-1: 1650.1s -> 1949.0s (+18.1%)
  4. armhf-gnu: 4702.8s -> 5519.2s (+17.4%)
  5. x86_64-gnu-llvm-20: 2413.6s -> 2821.9s (+16.9%)
  6. aarch64-apple: 8877.1s -> 10378.4s (+16.9%)
  7. x86_64-rust-for-linux: 2639.8s -> 3040.0s (+15.2%)
  8. x86_64-gnu-tools: 3008.1s -> 3460.1s (+15.0%)
  9. aarch64-gnu-llvm-20-2: 2271.5s -> 2608.2s (+14.8%)
  10. dist-sparcv9-solaris: 5866.3s -> 5052.6s (-13.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@Muscraft Muscraft deleted the update-annotate-snippets branch December 2, 2025 17:32
@rust-timer
Copy link
Collaborator

rust-timer commented Dec 2, 2025

Finished benchmarking commit (eca9d93): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.135s -> 471.361s (0.69%)
Artifact size: 386.71 MiB -> 386.74 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Muscraft @rustbot @jieyouxu @bors @rust-timer @davidtwco